Bugs and Issues - LSS

Argordejo Caught crash in execpthook

brummer

When trying to start agordejo (without install) it fail with the following message:

QTextBrowser: No document for index.html
[agordejo] ERROR 2022-07-18 18:17:51,641 engine.start: Caught crash in execpthook. Trying too execute atexit anyway
Traceback (most recent call last):
File "/home/brummer/projecte/Argodejo/build/agordejo", line 7, in <module>
mainwindow.MainWindow()
File "/home/brummer/projecte/Argodejo/build/qtgui/mainwindow.py", line 144, in __init__
self.changelog = Changelog(mainWindow=self)
File "/home/brummer/projecte/Argodejo/build/qtgui/changelog.py", line 55, in __init__
with open(PATHS["doc"] + "/CHANGELOG", "r") as f:
FileNotFoundError: [Errno 2]

this could be easily avoided by handle exceptions.

in changelog.py implement a try: hook for open the CHANGELOG.

try:
with open(PATHS["doc"] + "/CHANGELOG", "r") as f:
textEdit.setPlainText(f.read())
except IOError:
print("CHANGELOG not accessible")

RSS Only moderators or members can reply to this. Sign-in if you are a moderator or member in order to post.

Replies

#1. lss

You have tried only a partial installation (configure and make) and executed a temp build file to start.

You can either do a proper install or start locally. As the readme says:

You can also run Agordejo after extracting the release archive or cloning from git, without make or installation. If you did so, for additional features please link tools/nsm-data to your executable PATH.

#2. brummer

Don't know what to say here. Loading a file from the users local space, without doing any error checking and crashing over that, is, sorry me, stupid. Regardless if you assume that this file "should be there at any case because it is part of your package", or, if you open a new file for write to, it is, stupid to assume it is open. Check that before proceed. There could happen so many things in time between, noon remember that.

More over, as this file isn't in any case necessary to run the program.
A IOError checking should be done on any file load in python. Then, when needed, do a clean exit (clean up before you go), or, inform the user that the operation fail.
That is in no way a hack, that is what I call good practice.
You assumptions about how I have to start the program in all honor, nice would be if I could use a app without reading the fucking manual, and, here in that case it just didn't help anyway.

It pains me to see this app sold as "The Linux Audio Session Manager" while I see so careless handling of file IO.

#3. nedko

Self promotion of Agordejo + New Session Manager as *The* Linux Audio Session Manager is unethical toward projects providing other implementations. This includes but is not limited to the LADI session handler (ladish) and the NON Session Manager.

NewSM has various issues at technical level that don't exist in other session managers (they have their own issues and specifics tho). NewSM also changed the NSM OSC protocol, which IMO is quite against the wording in the NON NSM OSC API document.

I clearly see need of community version of NON Session Manager and space for alternative nsmd.C UIs, but binding this to linuxaudio.org or jackaudio.org is IMO damaging to the community because it is an expression of monoculture, rather than ethically well suited https://launchpad.net/codeofconduct/2.0

#4. lss

If you have actual bugs or problems please tell them as bug reports. This is just stirring fear and confusion.

If not, this is my personal bug tracker for Agordejo and the other LSS programs, which are my solo projects. Not a discussion place for NSM. Please go to https://github.com/jackaudio/new-session-manager for that

Nedko, LADISH is irrelevant. It was technically inferior to NSM from the start and you let it sit around without development or support for 8 years or so. Don't appear suddenly out of nowhere and try to make it a thing again. Session management works only if all clients and users use the same, and that turned out to be NSM. That is why I forked it and did not create my own one. When I do something for session management I think of the users, when you do session mangement you think only of yourself.

For the sake of transparency I'll let this bug report open for a while, eventhough you just hijacked a random bug report to say something. I'll give it a timeout of a month to 2022-09-23 because the original bug was either resolved or not reproducable (we checked over IRC)

:: @lss added on 22 08 23 · 16:18

Also the NON session manager, and all other NON projects, were deleted by the author quite some time ago. There is no NON Session Manager anymore.
Other server implementation of the NSM protocol are Carla and RaySession, but they don't use nsmd. Only Agordejo and the original FLTK NON gui use nsmd. And it is very very obvious that Agordejo is the better program of the two in any measurable way.

:: @lss added on 22 08 23 · 16:41

Just in case I was not clear enough.
The New-Session-Manager README contains the mission statement from day one:

"The goal is to become the de-facto standard music session manager for Linux distributions".
For the sake of the users.